-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: add cmake installation; add SIMPLEINI_USE_SYSTEM_GTEST option #72
Conversation
I'm happy that SimpleIni is getting some love from the CMake users, but it concerns me that none of these contributions are tested in any way by the build or test harness. What do you think about contributing a change so that build and execute of the test harness uses CMake? |
Just making some comments in this PR as I was asked for:
It would be nice to include some alternative GitHub workflow to test the cmake toolchain. |
Thanks for your advice, I will split it into two commits.
Yes, use system gtest and use |
Thank you for your contribution. |
Looking more into the cmake build harness, and I'm wondering why was the SIMPLEINI_USE_SYSTEM_GTEST option necessary? Wouldn't adding the package to the FetchContent_Declare statement be best, see Using Dependencies Guide? i.e. use the installed package and if not available then build it outselves:
|
The PR does the folllowing things, which will help for packaging in Linux when using CMake: