Disable X-XSS-Protection filter, for safety #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EvanHahn looks like some tests are failing |
|
I'll take a look. |
Surprisingly, [`X-XSS-Protection` is safer when disabled][0], and browsers are dropping support for it as a result. Because it's less safe to enable the filter, this change sets the default (and only) value to `0`, instead of `1; mode=block`. This is a breaking change. See [issue brokenhandsio#25][1]. [0]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection [1]: brokenhandsio#25
EvanHahn
force-pushed
the
disable-xss-filter
branch
from
114ce16
to
2900d3e
Compare
|
Should be fixed! My mistake. |
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 282 273 -9
=========================================
- Hits 282 273 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly,
X-XSS-Protectionis safer when disabled, and browsers are dropping support for it as a result. Because it's less safe to enable the filter, this change sets the default (and only) value to0, instead of1; mode=block.This is a breaking change.
See #25.