-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG_MIME doesn't work #117
Comments
I was trying to figure out what MIME was doing, and noticed some strange usage within the DEBUG_MIME section.. Ironically, it actually failed where @dougwilson has listed.. But even if it didn't, I think it would have failed in a different place if I am reading this correctly. if (process.env.DEBUG_MIME && this.types[exts]) {
console.warn(this._loading.replace(/.*\//, ''), 'changes "' + exts[i] + '" extension type from ' +
this.types[exts] + ' to ' + type);
} Correct me if I am wrong, but should I think I will make a Pull Request for this. |
This fixes broofa#117 `this._loading` is undefined/null if calling 'define()' directly, rather than via `load()`. `exts` incorrectly being used in `this.types[exts]`. Since exts is an array, it only works if the array holds a single value.
It throws ;)
The text was updated successfully, but these errors were encountered: