[BUGFIX] Value of 0.00 is not rendered when used in view helper

Resolves: #23
brotkrueml · Nov 3, 2019 · da490f9 · da490f9
1 parent 9b97d5c
commit da490f9
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 6 deletions.
diff --git a/Classes/Core/ViewHelpers/AbstractTypeViewHelper.php b/Classes/Core/ViewHelpers/AbstractTypeViewHelper.php
@@ -96,6 +96,7 @@ public function render()
     protected function checkSpecificTypeAttribute(): void
     {
         $specificTypeFromArguments = (string)($this->arguments[static::ARGUMENT_SPECIFIC_TYPE] ?? '');
+        unset($this->arguments[static::ARGUMENT_SPECIFIC_TYPE]);
 
         if (empty($specificTypeFromArguments)) {
             return;
@@ -114,8 +115,6 @@ protected function checkSpecificTypeAttribute(): void
         }
 
         $this->specificType = $specificTypeFromArguments;
-
-        unset($this->arguments[static::ARGUMENT_SPECIFIC_TYPE]);
     }
 
     protected function checkAsAttribute(): void
@@ -181,10 +180,6 @@ protected function assignArgumentsToItem(): void
         unset($this->arguments[static::ARGUMENT_ID]);
 
         foreach ($this->arguments as $name => $value) {
-            if (empty($value)) {
-                continue;
-            }
-
             $model->setProperty($name, $value);
         }
 

diff --git a/Tests/Unit/Core/Model/AbstractTypeTest.php b/Tests/Unit/Core/Model/AbstractTypeTest.php
@@ -368,6 +368,15 @@ public function dataProviderForToArrayReturnsCorrectResult(): iterable
             ],
         ];
 
+        yield 'Value is the number 0.10 as float' => [
+            'name',
+            0.10,
+            [
+                '@type' => 'FixtureThing',
+                'name' => '0.1',
+            ],
+        ];
+
         yield 'Value is a model' => [
             'image',
             (new FixtureImage())

diff --git a/Tests/Unit/ViewHelpers/Type/ThingViewHelperTest.php b/Tests/Unit/ViewHelpers/Type/ThingViewHelperTest.php
@@ -138,6 +138,22 @@ public function fluidTemplatesProvider(): iterable
                 </schema:type.thing>',
             '<script type="application/ld+json">{"@context":"http://schema.org","@type":"WebPage","mainEntity":{"@type":"Thing","@id":"parentThing","name":"parent name","subjectOf":{"@type":"Person","@id":"childThing","name":"child name","url":"https://example.org/child"},"url":"http://example.org/"}}</script>',
         ];
+
+        yield 'Property value of 0.00 is rendered' => [
+            '<schema:type.offer
+                price="0.00"
+                priceCurrency="EUR"
+             />',
+            '<script type="application/ld+json">{"@context":"http://schema.org","@type":"Offer","price":"0","priceCurrency":"EUR"}</script>',
+        ];
+
+        yield 'Property value of 0.01 is rendered' => [
+            '<schema:type.offer
+                price="0.01"
+                priceCurrency="EUR"
+             />',
+            '<script type="application/ld+json">{"@context":"http://schema.org","@type":"Offer","price":"0.01","priceCurrency":"EUR"}</script>',
+        ];
     }
 
     /**