-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize collections #33
Conversation
That's an interesting question! My initial thought was no, we probably only want admins to edit the text. I think lede can be the first sentence ellipsized. I'm thinking that header images should be static, but I don't hold strong convictions here. @galenwinsor what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! How does the i18n work for static cms?
Users of our site would like to set up everything in english and then hire translators for various locales. StaticCMS requires a minimum of two locales to be declared in the i18n section of the config, so english-only would not be an option; additionally, setting any field as "i18n: true" REQUIRES translation. Removing these field declarations maintains the folder structure we need.
Visit the preview URL for this PR (updated for commit 12d948f): https://mmp-site-b1c9b--pr33-cms-collections-u3khwezm.web.app (expires Mon, 18 Mar 2024 14:59:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4eb870c89e876f1812e204af417359065d2a23b1 |
We probably want to talk about this more, but I req a review so that you can take a look at the structure.
Question for reviewers: Do we want to allow editing of general page content (like a lede and header image, for example)?
To test locally:
Open a terminal and run
In a separate terminal, run
Go to http://localhost:4321/admin/index.html