This repository has been archived by the owner on Feb 11, 2025. It is now read-only.
experiment ui wrapper prototype #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untitled.mov |
hollandjg
suggested changes
Sep 9, 2024
Comment on lines
147
to
187
| def format_tree_with_indices(tree: py_trees.behaviour.Behaviour, mode: str = "all") -> str: | ||
| """ | ||
| Examples: | ||
| >>> print(format_tree_with_indices(py_trees.behaviours.Dummy())) | ||
| 0: --> Dummy | ||
|
|
||
| >>> tree = py_trees.composites.Sequence("s1", False, children=[ | ||
| ... py_trees.behaviours.Dummy(), | ||
| ... py_trees.behaviours.Success(), | ||
| ... py_trees.composites.Sequence("s2", False, children=[ | ||
| ... py_trees.behaviours.Dummy(), | ||
| ... ]), | ||
| ... py_trees.composites.Sequence("", False, children=[ | ||
| ... py_trees.behaviours.Failure(), | ||
| ... py_trees.behaviours.Periodic("p", n=1), | ||
| ... ]), | ||
| ... ]) | ||
| >>> print(format_tree_with_indices(tree)) # doctest: +NORMALIZE_WHITESPACE | ||
| 0: [-] s1 | ||
| 1: --> Dummy | ||
| 2: --> Success | ||
| 3: [-] s2 | ||
| 4: --> Dummy | ||
| 5: [-] | ||
| 6: --> Failure | ||
| 7: --> p | ||
|
|
||
| """ | ||
| index_strings = [] | ||
| index = 0 | ||
| for i, node in enumerate_nodes(tree): | ||
| if mode == "children" and node.children: | ||
| # Do not number parent nodes in 'children' mode | ||
| index_strings.append('_') | ||
| elif mode == "parents" and not node.children: | ||
| # Do not number child nodes in 'parents' mode | ||
| index_strings.append('_') | ||
| else: | ||
| # Number all nodes in 'all' mode | ||
| index_strings.append(str(index)) | ||
| index += 1 |
There was a problem hiding this comment.
I'd love to see some tests of this – you can copy and modify the existing doctest to show how to use the mode switch.
src/social_norms_trees/ui_wrapper.py
Outdated
|
|
||
|
|
||
| def load_db(): | ||
| if os.path.exists(DB_FILE): |
There was a problem hiding this comment.
What happens if someone wants to load a file and puts in the argument with the name, but it doesn't exist? I'd expect there to be an error "IOError: File Doesn't Exist" or something like that, but this will fail quietly.
How about we make this just throw the error if you give it a file name which doesn't exist, and if you don't give it a file name then it returns the empty dictionary?
Co-authored-by: John Gerrard Holland <john_holland1@brown.edu>
hollandjg
approved these changes
Sep 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walkthrough of the UI simulation