Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the custom hardcoded libCST commands #114

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Remove the custom hardcoded libCST commands #114

merged 2 commits into from
Jun 18, 2020

Conversation

browniebroke
Copy link
Owner

@browniebroke browniebroke commented Jun 18, 2020 •
edited
Loading

Now that we have a CLI with flexible options, we shouldn't need these.

@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        17    -1     
  Lines          450       436   -14     
=========================================
- Hits           450       436   -14
Impacted Files Coverage Δ
django_codemod/cli.py 100.00% <100.00%> (ø)
django_codemod/commands.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8953ec8...9271785. Read the comment docs.

@browniebroke browniebroke added the removed Removed piece of functionalities. label Jun 18, 2020
@browniebroke browniebroke changed the title Remove the hardcoded commands for libCST Remove the custom hardcoded commands for libCST Jun 18, 2020
@browniebroke browniebroke changed the title Remove the custom hardcoded commands for libCST Remove the custom hardcoded libCST commands Jun 18, 2020
@browniebroke browniebroke merged commit f583e6a into master Jun 18, 2020
@browniebroke browniebroke deleted the remove-commands branch June 18, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
removed Removed piece of functionalities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@browniebroke