Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI command to list all codemodders #156

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Conversation

browniebroke
Copy link
Owner

Codemodders are listed as a table using the rich package

Fixes #75

@browniebroke browniebroke added the enhancement New feature or request label Jul 26, 2020
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          547       585   +38     
=========================================
+ Hits           547       585   +38     
Impacted Files Coverage Δ
django_codemod/visitors/core.py 100.00% <ø> (ø)
django_codemod/visitors/decorators.py 100.00% <ø> (ø)
django_codemod/visitors/encoding.py 100.00% <ø> (ø)
django_codemod/visitors/html.py 100.00% <ø> (ø)
django_codemod/visitors/http.py 100.00% <ø> (ø)
django_codemod/visitors/lru_cache.py 100.00% <ø> (ø)
django_codemod/visitors/os_utils.py 100.00% <ø> (ø)
django_codemod/visitors/shortcuts.py 100.00% <ø> (ø)
django_codemod/visitors/translations.py 100.00% <ø> (ø)
django_codemod/visitors/urls.py 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e666f...9caada8. Read the comment docs.

@browniebroke browniebroke force-pushed the list-command branch 3 times, most recently from 8b36238 to b12bdd6 Compare July 26, 2020 20:32
Codemodders are listed as a table using the rich package
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 26, 2020

Sourcery Code Quality Report (beta)

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.27 1.27 0.00
Method Length 37.88 37.90 0.02 🔴
Quality 8.97 8.97 0.00
Other metrics Before After Change
Lines 998 1072 74
Changed files Quality Before Quality After Quality Change
django_codemod/cli.py 8.66 8.77 0.11 🔵
django_codemod/visitors/admin.py 8.56 8.56 0.00
django_codemod/visitors/base.py 9.33 9.32 -0.01 🔴
django_codemod/visitors/core.py 9.48 9.48 0.00
django_codemod/visitors/decorators.py 9.12 9.12 0.00
django_codemod/visitors/encoding.py 8.73 8.73 0.00
django_codemod/visitors/html.py 9.48 9.48 0.00
django_codemod/visitors/http.py 8.08 8.08 0.00
django_codemod/visitors/lru_cache.py 9.48 9.48 0.00
django_codemod/visitors/models.py 8.42 8.42 0.00
django_codemod/visitors/os_utils.py 9.48 9.48 0.00
django_codemod/visitors/shortcuts.py 9.60 9.60 0.00
django_codemod/visitors/translations.py 8.08 8.08 0.00
django_codemod/visitors/urls.py 9.09 9.09 0.00
tests/test_cli.py 9.12 9.11 -0.01 🔴

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
django_codemod/visitors/models.py ModelsPermalinkTransformer.leave_ImportFrom 21 178.88 4.45 Split out functionality
django_codemod/visitors/admin.py InlineHasAddPermissionsTransformer.leave_ImportFrom 16 171.86 4.97 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@browniebroke browniebroke merged commit 9b41137 into master Jul 26, 2020
@browniebroke browniebroke deleted the list-command branch July 26, 2020 20:42
@browniebroke browniebroke added this to the Django Codemod v1.0 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List supported codemod from command line
1 participant