Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support renaming of usages of function without calls #197

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

browniebroke
Copy link
Owner

No description provided.

@browniebroke browniebroke added the bug Something isn't working label Sep 15, 2020
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 15, 2020

Sourcery Code Quality Report (beta)

❌  Merging this PR will decrease code quality in the affected files by 0.01 out of 10.

Quality metrics Before After Change
Complexity 0.54 0.56 0.02 🔴
Method Length 22.14 22.33 0.19 🔴
Quality 9.40 9.39 -0.01 🔴
Other metrics Before After Change
Lines 309 344 35
Changed files Quality Before Quality After Quality Change
django_codemod/visitors/base.py 9.32 9.32 0.00
tests/visitors/test_base.py 9.50 9.51 0.01 🔵

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          602       618   +16     
=========================================
+ Hits           602       618   +16     
Impacted Files Coverage Δ
django_codemod/visitors/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486912e...9c89652. Read the comment docs.

@browniebroke browniebroke merged commit fcde77f into master Sep 15, 2020
@browniebroke browniebroke deleted the fix/reassigned-function branch September 15, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant