Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecation of django.utils.http.is_safe_url in Django 3.0 #72

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

browniebroke
Copy link
Owner

From Django 3.0 release notes:

To avoid possible confusion as to effective scope, the private internal utility is_safe_url() is renamed to url_has_allowed_host_and_scheme(). That a URL has an allowed host and scheme doesn’t in general imply that it’s “safe”. It may still be quoted incorrectly, for example. Ensure to also use iri_to_uri() on the path component of untrusted URLs.

@browniebroke browniebroke added the enhancement New feature or request label Jun 2, 2020
@browniebroke browniebroke merged commit 4b39dd4 into master Jun 2, 2020
@browniebroke browniebroke deleted the feature/is-safe-url branch June 2, 2020 21:51
@browniebroke browniebroke added this to the Django 4.0 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant