Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from WurflCache to Symfony Cache #185

Closed
wants to merge 3 commits into from

Conversation

grimsonmarc
Copy link

Removed all references that I could find to the Wurfl cache implementation.

Sorry, I had removed the Memcache part of the README, Symfony does have a Memcache implementation but I didn't get around to updating the README with that information.

Should also note that this is using a dev version of the Symfony Cache since they haven't released a release version using PSR-16 yet (at least when I had made these changes)

@asgrim
Copy link
Member

asgrim commented Feb 28, 2017

As discussed in #174, we actually plan to use doctrine/cache with the roave/doctrine-simplecache adapter. This is already stable and released, and means we can bump minimum PHP version to 7.1 (this is a good thing). I really wish you'd discussed before creating the proposal, sorry :(

@grimsonmarc
Copy link
Author

It's all good, just needed a quick update due to the Wurfl license, but I'll be happy to switch back to the main branch once doctrine/cache is added in as a replacement. Would you like me to close the pull request?

@asgrim asgrim closed this Mar 27, 2017
@asgrim asgrim added the wontfix label Mar 27, 2017
@asgrim asgrim self-assigned this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants