Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen monolog constraint to include 2.0 #263

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Widen monolog constraint to include 2.0 #263

merged 3 commits into from
Oct 18, 2019

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Sep 30, 2019

Fixes #262

@asgrim asgrim requested a review from mimmi20 September 30, 2019 12:03
@asgrim asgrim self-assigned this Sep 30, 2019
@codecov-io
Copy link

codecov-io commented Sep 30, 2019 •
edited
Loading

Codecov Report

Merging #263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #263   +/-   ##
=========================================
  Coverage     40.99%   40.99%           
  Complexity      299      299           
=========================================
  Files            27       27           
  Lines           927      927           
=========================================
  Hits            380      380           
  Misses          547      547
Flag Coverage Δ Complexity Δ
#phpunit 40.99% <ø> (ø) 299 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ca3db...031c243. Read the comment docs.

@dsazup
Copy link

dsazup commented Oct 17, 2019

Any chance this will be merged soon?

@asgrim asgrim merged commit f85bb5d into master Oct 18, 2019
@asgrim asgrim deleted the widen-monolog-compatibility branch October 18, 2019 07:47
@asgrim
Copy link
Member Author

asgrim commented Oct 18, 2019

Thanks for the ping @dsazup !

@asgrim asgrim added this to the 4.3.0 milestone Oct 18, 2019
@asgrim
Copy link
Member Author

asgrim commented Oct 18, 2019

This is released in 4.2.1 👍

@JanMikes
Copy link

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimmi20 mimmi20 mimmi20 approved these changes

Assignees

@asgrim asgrim

Labels
enhancement
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

Update monolog/monolog dependency
5 participants
@asgrim @codecov-io @dsazup @JanMikes @mimmi20