Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3 support #640

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add PHP 8.3 support #640

merged 3 commits into from
Nov 21, 2023

Conversation

Slamdunk
Copy link
Contributor

No description provided.

Copy link
Member

@mimmi20 mimmi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add experimental support for PHP 8.4

.github/workflows/continuous-integration.yml Show resolved Hide resolved
@asgrim
Copy link
Member

asgrim commented Nov 21, 2023

Hmm not sure why the build hasn't run here, it's not asking to approve the pipeline either?

@Slamdunk
Copy link
Contributor Author

Fun fact: the build had a successful run on my fork https://github.com/Slamdunk/browscap-php/actions/runs/6941392168

@asgrim
Copy link
Member

asgrim commented Nov 21, 2023

Hmm not sure why the build hasn't run here, it's not asking to approve the pipeline either?

@Slamdunk please could you try rebasing, I've just merged #642 which hopefully will fix the build not running

@asgrim asgrim added this to the 7.3.0 milestone Nov 21, 2023
@asgrim asgrim self-assigned this Nov 21, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c793aaa) 36.26% compared to head (699fcfc) 36.26%.
Report is 2 commits behind head on 7.3.x.

Additional details and impacted files
@@            Coverage Diff            @@
##              7.3.x     #640   +/-   ##
=========================================
  Coverage     36.26%   36.26%           
  Complexity      286      286           
=========================================
  Files            27       27           
  Lines          1183     1183           
=========================================
  Hits            429      429           
  Misses          754      754           
Flag Coverage Δ
phpunit 36.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asgrim
Copy link
Member

asgrim commented Nov 21, 2023

@Slamdunk thank you - this all green now :)

@asgrim asgrim merged commit 1e81084 into browscap:7.3.x Nov 21, 2023
45 checks passed
@Slamdunk Slamdunk deleted the php_83 branch November 21, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants