more ecdsa #29
Merged
more ecdsa #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is what I used to generate the new fixtures |
|
Were there any shortcomings with this? I manually patched on my end and it seems fine and also fixes a bug I'm having with a JWS library used in Node (that I downstream patched in tandem) auth0/node-jwa#8 Basically, that guy uses some tricks (pretending to be doing RSA-SHA) to end up in OpenSSL where ECDSA will be handled correctly, but those tricks don't work in browser obviously. However with the patch here, and a patch over there, I can get that library to work with this one |
|
Have not verified with external software, but the fixtures look good. @calvinmetcalf any easy way to compare these? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should solve #28, needs tests