Fix exposed requires being persisted across bundles #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latentflip
added a commit
to HenrikJoreteg/moonboots
that referenced
this pull request
Dec 17, 2014
… was causing by issues in browserify related to: browserify/browserify#1030
|
LGTM 👍 @substack ? |
|
I think the root cause of this might be a bug in module-deps, which I've been trying to get to the bottom of. I asked about it in browserify/module-deps/pull/65, but it was merged without comment (so far). Long story short, with the way I'm proposing resolving pathnames of exposed modules, it gets them treated as built-in (e.g. transforms aren't run). More info in /pull/1077. So I think something needs to change in module-deps re: that anyway, and it might solve the problem you're talking about as well. |
|
I'll have a patch fix for this soon once I finish the v9 branch. |
ghost
merged commit
|
Published in 9.0.1. Thanks for the patch! |
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the comments on issue #908 #908 (comment),
exposed files were being persisted across calls to browserify. I tracked this down to a leak where modules were being appended to the (module) global builtins object. Fixed with a test, though I'm not sure if you want a test for such a fine grained bug, so feel free to remove it, but it does demonstrate the failure & subsequent pass with this fix.