-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative paths in noparse option #2080
Relative paths in noparse option #2080
Conversation
This comment was marked as spam.
This comment was marked as spam.
This will need a regression test. |
@ljharb Hello, you mean new tests/test in which I have to check passing relative paths for |
I mean a test that would fail without the changes in this PR. |
@ljharb Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that the test fails without your fix, and passes with it, this LGTM modulo nits
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
This comment was marked as spam.
This comment was marked as spam.
Released in 📦 17.0.1. Thank you! |
Browserify command with relative paths via
--noparse
option doesn't work. If I pass full paths in the option everything works as expected. Digging the problem I noticed thatnoparse
array are passed intomodule-deps
class via constructor. And in this package there is no processing the array like in browserify package (basedir+cwd+file name in noparse array).