Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sourceMapPrefix from //@ to //# #587

Closed
wants to merge 1 commit into from

Conversation

guybrush
Copy link
Contributor

@guybrush guybrush commented Jan 6, 2014

please feel free to ignore this PR and fix it however you want if it doesnt fit!

@TimBeyer
Copy link

👍
//@ breaks IE compatibility

@feross
Copy link
Member

feross commented Jan 17, 2014

It's true. IE9 throws an error and doesn't run JS when it sees this in a
file.

On Friday, January 17, 2014, Dan Peddle notifications@github.com wrote:

pleeease merge this! <3 it's causing us grief on IE :(


Reply to this email directly or view it on GitHubhttps://github.com//pull/587#issuecomment-32598265
.

Feross
✩ blog http://feross.org/ | ✎ studynotes http://www.apstudynotes.org/ |☮
webtorrent http://webtorrent.io/

@dazld
Copy link

dazld commented Jan 21, 2014

I know that testing in IE is about as much fun as jumping into a wall, but this one line fix would mean we don't have to make it even worse...

Here's what happens every single time we load our dev version up for testing.

screen shot 2014-01-21 at 11 22 08 am

@ghost
Copy link

ghost commented Jan 21, 2014

It's probably been long enough for this now. Merged in 3.22.0.

@ghost ghost closed this Jan 21, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants