Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit close event on bundle stream with standalone #608

Closed

Conversation

tonistiigi
Copy link
Contributor

Currently watchify does not work with standalone option because the bundle stream does not emit close event.

When this.queue(null) is called through emits end event but because the stream is also writable it does not get destroyed. Other way to fix it would be to set output.writable = false.

The test got a bit hacky because when bundle() is called before _ready event the bug does not appear because it gets wrapped into another through stream.

@ghost
Copy link

ghost commented Jan 28, 2014

Published in 3.24.2. Thanks for the patch!

@ghost ghost closed this Jan 28, 2014
@tonistiigi
Copy link
Contributor Author

I think you forgot to push to github.

$ curl -s https://raw.github.com/substack/node-browserify/master/package.json | json version
3.24.1
$ npm view browserify version
3.24.2

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant