Emit close event on bundle stream with standalone #608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
watchify
does not work withstandalone
option because the bundle stream does not emitclose
event.When
this.queue(null)
is calledthrough
emitsend
event but because the stream is also writable it does not get destroyed. Other way to fix it would be to setoutput.writable = false
.The test got a bit hacky because when
bundle()
is called before_ready
event the bug does not appear because it gets wrapped into anotherthrough
stream.