-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose strict mode functionality #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks, just one compatibility comment :)
@goto-bus-stop addressed feedback, let me know if Also resolved some of the issues with the tests here: #42 |
I think the buffer shim is inlined because recent buffer versions don't work at all on old IE (throws an error on load). object-assign should be ok, it seems like |
Ahhhh, that makes sense.
That would be great, thanks! |
@goto-bus-stop is this ok to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, turns out this module already only works in IE9+ because of Object.getPrototypeOf
. thanks!
@goto-bus-stop should we publish a new release with this? I don't have npm permissions. |
ideally yes! i don't have publish perms either :' @defunctzombie do you have a moment to give the browserify org members publish access on npm?
|
(or @calvinmetcalf or @solderjs) 🙏 |
Any update on this? |
📦 1.5.0 🎉 |
This PR adds support for using
assert
in strict mode.Resolves: #37
Makes some progress towards: #32
Ported from this Node.js PR: nodejs/node#17002
Tests are all failing. This isn't due to any changes in this PR they are already failing in master: #33
I've tested locally on a couple of different Node.js versions and tests are passing but would feel a lot more confident getting this properly tested against all browser targets.
Happy to look into the Travis issue and submit a separate PR resolving that if you want.