Fix deepEqual for ES6 Object.keys #7
Merged
+25
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.keys
is changed in ES6. It no longer throws errors for primitives.http://people.mozilla.org/~jorendorff/es6-draft.html#sec-object.keys
Next Chrome 40 and Firefox 35 will change
Object.keys
for ES6.and then,
assert.deepEqual
will be broken.FYI: io.js has fixed same issue nodejs/node#193