Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepEqual for ES6 Object.keys #7

Merged
merged 1 commit into from
Dec 24, 2014

Conversation

teppeis
Copy link
Contributor

@teppeis teppeis commented Dec 23, 2014

Object.keys is changed in ES6. It no longer throws errors for primitives.
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-object.keys

Next Chrome 40 and Firefox 35 will change Object.keys for ES6.

and then, assert.deepEqual will be broken.

FYI: io.js has fixed same issue nodejs/node#193

@defunctzombie
Copy link
Contributor

Is this backwards compatible with current behavior?

@teppeis
Copy link
Contributor Author

teppeis commented Dec 24, 2014

@defunctzombie yes, compatible!
I added over 10 test cases to keep compatibility, and I confirmed that the tests passed in every current browser in addition to Chrome beta and Firefox beta with zool (using my saucelabs account).

defunctzombie added a commit that referenced this pull request Dec 24, 2014
Fix deepEqual for ES6 Object.keys
@defunctzombie defunctzombie merged commit 98c05e5 into browserify:master Dec 24, 2014
@teppeis teppeis deleted the es6-object-keys branch December 24, 2014 03:48
@teppeis
Copy link
Contributor Author

teppeis commented Dec 24, 2014

thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants