feat: add a new noble-based implementation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
force-pushed
the
chalker/noble/0
branch
from
10bf98a
to
b6e4850
Compare
ChALkeR
changed the title
ChALkeR
changed the title
ChALkeR
force-pushed
the
chalker/noble/0
branch
11 times, most recently
from
eb53eec
to
e442cc6
Compare
ljharb
force-pushed
the
chalker/noble/0
branch
3 times, most recently
from
b01a871
to
53fa3fa
Compare
ljharb
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
@noble/hashesas a polyfill in newer environments where it worksAlso adds support for:
sha512-224,sha512-256,sha3-224,sha3-256,sha3-384,sha3-512,blake2b512andblake2s256Node.js-based default
./inde.jsalready supports those through Node.js/OpenSSL, so different support level shouldn't be an issue. Also, the old browser impl here doesn't limitsha.jslist of supported hashes and the list depends onsha.jsversion / can change outside of this lib.The new version is used only when the env supports
BigIntand when importing noble-based implementation doesn't failSo this should be compatible with all currently supported versions and be a semver-minor change
Test changes better viewed with whitespace ignored, I had to shift the whole existing test to run it on bold old and new implementations.