Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createECDH #63

Closed
calvinmetcalf opened this issue Nov 5, 2014 · 12 comments
Closed

createECDH #63

calvinmetcalf opened this issue Nov 5, 2014 · 12 comments

Comments

@calvinmetcalf
Copy link
Contributor

eleptical curve diffie helman is in node 0.11 looks like @indutny has a library that we could wrap to create the node api

@dominictarr
Copy link
Contributor

Oh, I did not know that node 11 had that!
hmm, would be awesome if it also had createSign and createVerify for elliptic curves

@calvinmetcalf
Copy link
Contributor Author

good thing that library has that ability

@calvinmetcalf
Copy link
Contributor Author

wait you were talking about node which does not (at the moment in it's docs)

On Wed, Nov 5, 2014 at 7:23 AM, Dominic Tarr notifications@github.com
wrote:

Oh, I did not know that node 11 had that!
hmm, would be awesome if it also had createSign and createVerify for
elliptic curves


Reply to this email directly or view it on GitHub
#63 (comment)
.

-Calvin W. Metcalf

@calvinmetcalf
Copy link
Contributor Author

actually I take that back it appears you can use eliptic curves to sign in 0.10! (verified locally) nodejs/node-v0.x-archive#6904 (comment)

@dominictarr
Copy link
Contributor

Hmm, oh this is very good,
but it seems like it is only EHDSA with sha1... which is being depreciated.
hmm, also we have crypto.getCiphers and crypto.getHashes but no crypto.getSigners.

@calvinmetcalf
Copy link
Contributor Author

do you think it's a good idea to add createECDH to the current dh pull (and do the sign/verify stuff latter on) or do it in a separate one'?

@dominictarr
Copy link
Contributor

I added this: nodejs/node-v0.x-archive#6268

@dominictarr
Copy link
Contributor

well, although DiffieHellman and ECDH basically do the same thing they do it in totally different ways, so I think it should be separate PRs.

@calvinmetcalf
Copy link
Contributor Author

I was more thinking in terms of whether to put it in the same module as much of the code is just converting between bn.js arrays and buffers which would end up being the same

@dominictarr
Copy link
Contributor

aha! that should be a third module, or a pull request to bn.js

@calvinmetcalf
Copy link
Contributor Author

@calvinmetcalf
Copy link
Contributor Author

er to expand (didn't mean to hit enter so quickly) preliminary ecdh, likely not worth bringing in until 0.12 though.

The eliptical library uses it's own source of randomness which I am able to override but it's still in there as a dep, also uses it's own hash library, debating if it would make sense to do a fork with our specific needs.

Additionally only has one curve in common with openssl, but from what I can tell open ssl has a fairly poor choice of curves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants