-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createECDH #63
Comments
Oh, I did not know that node 11 had that! |
good thing that library has that ability |
wait you were talking about node which does not (at the moment in it's docs) On Wed, Nov 5, 2014 at 7:23 AM, Dominic Tarr notifications@github.com
-Calvin W. Metcalf |
actually I take that back it appears you can use eliptic curves to sign in 0.10! (verified locally) nodejs/node-v0.x-archive#6904 (comment) |
Hmm, oh this is very good, |
do you think it's a good idea to add createECDH to the current dh pull (and do the sign/verify stuff latter on) or do it in a separate one'? |
I added this: nodejs/node-v0.x-archive#6268 |
well, although DiffieHellman and ECDH basically do the same thing they do it in totally different ways, so I think it should be separate PRs. |
I was more thinking in terms of whether to put it in the same module as much of the code is just converting between bn.js arrays and buffers which would end up being the same |
aha! that should be a third module, or a pull request to bn.js |
er to expand (didn't mean to hit enter so quickly) preliminary ecdh, likely not worth bringing in until 0.12 though. The eliptical library uses it's own source of randomness which I am able to override but it's still in there as a dep, also uses it's own hash library, debating if it would make sense to do a fork with our specific needs. Additionally only has one curve in common with openssl, but from what I can tell open ssl has a fairly poor choice of curves. |
eleptical curve diffie helman is in node 0.11 looks like @indutny has a library that we could wrap to create the node api
The text was updated successfully, but these errors were encountered: