Added generateKeyPair #186
Conversation
|
tests? |
|
How do i create tests if key gen is randomized? |
|
Any news? |
|
@lmarianski could you add a test that makes sure that the outputs of this are valid inputs |
|
Oh yeah i forgot about this, i'll try to put something together, any ideas on what would the test actually entail? (besides the actual key generation, to make sure all is working) |
|
Also, any ideas as to why it's freaking out about the template string I use in my package? |
|
Anyways, added some tests, hope those will do, let me know if I should add anything else, and btw the whole test suite does pass for me locally (maybe its due to the travis script using older nodejs versions?) |
|
ok great will take a look |
|
we need to bump the node version in the .travis file, maybe to 10 or 12, I
forget which is currently stable
…On Fri, Jul 31, 2020 at 3:48 PM Łukasz Mariański ***@***.***> wrote:
Anyways, added some tests, hope those will do, let me know if I should add
anything else, and btw the whole test suite does pass for me locally
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/crypto-browserify/crypto-browserify/pull/186#issuecomment-667321068>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAITRH6H4N5PFYXTZMD4X63R6MNYDANCNFSM4IKCS5HQ>
.
--
-Calvin W. Metcalf
|
|
Do i just bump all the node versions in that file to LTS (v12)? |
|
yes please |
|
I'm waiting for this feature. When this feature would be available? 🙋🙋🙋 |
|
checks need to pass first |
|
actually @lmarianski you need to avoid requring crypto and instead require the specific libraries you need, what you need to do here is make 2 versions, one for node one for the browser and have a switch in the package.json |
|
Any news? |
1 similar comment
|
Any news? |
| env: TEST_SUITE=browser BROWSER_NAME=safari BROWSER_VERSION="7..latest" | ||
| - node_js: '4' | ||
| - node_js: '12' |
There was a problem hiding this comment.
These versions shouldn’t be changed; altho it’d be fine to add new matrix jobs.
|
Any news? |
Added an implementation of generateKeyPair using the WebCryptoAPI