Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node.js 8 events API #40

Merged
merged 8 commits into from
Jan 30, 2018
Merged

Update to Node.js 8 events API #40

merged 8 commits into from
Jan 30, 2018

Conversation

cedx
Copy link
Contributor

@cedx cedx commented Sep 9, 2017

Let's try again! @defunctzombie, @connor4312, I don't want this package to be abandoned :)

This PR fixes issue #29. As for the PR #32, the code was copied from Node.js source and adapted:

  • removed references to domain and process
  • replaced ES template strings by concatenation
  • replaced const statements by var ones

Disabled specific Node.js bits: domain and process.
Also replaced a template string by concatenation.
Because it is created using `Object.create(null)` in the `events` module.
@defunctzombie
Copy link
Collaborator

@cedx I no longer have time to maintain this package. I'd ping @Gozala and see if they will make you a maintainer.

@cedx
Copy link
Contributor Author

cedx commented Sep 9, 2017

Anyone knows how to fix the zull error raised by the unit tests?

Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided.

@cedx
Copy link
Contributor Author

cedx commented Sep 9, 2017

@defunctzombie Thanks, it would be a pleasure to help maintaining this project.

@cedx
Copy link
Contributor Author

cedx commented Oct 26, 2017

@Gozala Do you still maintain this project? Or should we switch to another package like eventemitter3?

@Gozala
Copy link
Collaborator

Gozala commented Oct 26, 2017

@cedx @defunctzombie has being maintaining it for quite some time now, but it looks like he's no longer able. I'm happy to let you take over since @defunctzombie seems to be onboard with that as well.

@Gozala
Copy link
Collaborator

Gozala commented Oct 26, 2017

@cedx I just have added you to the collaborators list, if you'll tell me your npm name I'll add you there as well.

@goto-bus-stop
Copy link
Member

hey, i'm very interested in getting this in--any way i can help out?

@Gozala
Copy link
Collaborator

Gozala commented Jan 1, 2018

@goto-bus-stop wanna take over this pull so it actually passes test ?

@goto-bus-stop
Copy link
Member

@Gozala I think the test failure is because this is a PR, and travis doesn't expose the SauceLabs authentication keys to PR builds (only branch builds). the tests themselves pass, but CI can't talk to saucelabs. it should turn green after merge

@Gozala Gozala merged commit 580b99a into browserify:master Jan 30, 2018
@Gozala
Copy link
Collaborator

Gozala commented Jan 30, 2018

It seems like this is still failing on IE 8/9. Sadly I don't have no time to put into this if someone want's to fix help maintain this project comment on #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants