Don't flag file as not resolvable too early #39
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After hours of tracing, I found my bug of the day!
When looking for a package, say
./lib/package.json
, the file is sometimes marked as unresolvable, even if./package.json
exists. Whether this works or not depends on the order offs.readFile
yields. Thenext()
implementation already flags the file as unresolvable correctly when there are no directories left to check.Also, this line causes module-deps to return an empty object with just the
__dirname
in it, which makes browserify work in this case. However, I have abrowserify.transform
field in thepackage.json
which is then not present, hence the transform is never invoked.Maybe you have some idea on how to improve error handling in this case.