Fix mysteriously disappearing "expose" and "entry" #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2015
|
cc: @terinjokes |
ghost
merged commit 
|
Looks great, thanks for all the work! |
|
Thanks @substack! 😄 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nasty race condition that would result in disappearing
exposeandentryon rows (see browserify/watchify#177).This happens when an input row (A) depends on another module that is also input row (B), and A finishes the dep parsing before B has resolved. This dependence is very typical with React. One module finishing parsing before another has even resolved happens pretty much always with watchify caching.
The solution proposed is to simply wait until the input rows have been resolved before continuing with their deps.
Out of the 4 tests added, only "test/cache_partial_expose.js" illustrates this bug. The rest are there because caching had no tests. I also tested Browserify with this fix and it all checks out.
cc: @jmm @substack