Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add util.promisify and util.callbackify #25

Merged
merged 4 commits into from
Jun 8, 2018
Merged

Add util.promisify and util.callbackify #25

merged 4 commits into from
Jun 8, 2018

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Mar 14, 2018 •
edited
Loading

(Tests still failing on Safari 11)

Closes #21

@goto-bus-stop
Copy link
Member Author

goto-bus-stop commented Mar 21, 2018 •
edited
Loading

@defunctzombie This is pretty much ready, but there is a test failure in Safari 11 on Sauce Labs that I can't reproduce. Is it possible for me to get access to the sauce labs dashboard for this project somehow?
Figured it out!

@billiegoose billiegoose mentioned this pull request Apr 13, 2018
Closed
@goto-bus-stop goto-bus-stop merged commit 2c65d29 into master Jun 8, 2018
@goto-bus-stop goto-bus-stop deleted the promisify-callbackify branch June 8, 2018 08:58
@domenic domenic mentioned this pull request Oct 8, 2018
Open
@holgerd77 holgerd77 mentioned this pull request Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@goto-bus-stop