-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught error (sync nor async) if main field is not a string #178
Comments
main for this package is:
|
@unlight either way, that package is broken; main can only be a string. I’d file a bug on that package. |
The question is how can I detect that package is broken. |
For sure, I definitely think this is a bug :-) |
Thanks for the perfect repro - a fix will be merged shortly, and included in the next release. |
ljharb
added a commit
to ljharb/resolve
that referenced
this issue
Dec 17, 2018
ljharb
added a commit
to ljharb/resolve
that referenced
this issue
Dec 17, 2018
ljharb
added a commit
that referenced
this issue
Dec 17, 2018
- [New] `async`/`sync`/`node-modules-paths`: Adds support for “paths” being a function (#172, #173) - [New] Implements a "normalize-options" pseudo-hook (#174) - [Fix] `sync`/`async`: fix `preserveSymlinks` option (#177) - [Fix] `sync`/`async`: when package.json `main` is not a string, throw an error (#178) - [Deps] update `path-parse` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `object-keys`, `safe-publish-latest`, `tape` - [Tests] up to `node` `v11.4`, `v10.14`, `v8.14`, `v6.15` - [Tests] better failure messages
ljharb
added a commit
that referenced
this issue
Jan 21, 2019
- [New] `core`: add `worker_threads` in v11.7+ - [Fix] `sync`/`async`: when package.json `main` is not a string, throw an error (#178) - [Fix] TypeError: Path must be a string. Received undefined (#181) - [Tests] up to `v11.6`, `v10.15`, `v8.15`, `v6.16` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `tape`
This was referenced Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How to repeat:
Actual:
Expected:
Error should be caught in callback or in catch
Related issues:
unlight/sublime-import-helper#61
zavoloklom/material-design-iconic-font#111
The text was updated successfully, but these errors were encountered: