Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'test' directory seems to contain the code of malicious package 'monorepo-symlink-test' #305

Closed
lanzkron opened this issue Jun 20, 2023 · 1 comment
Closed

The 'test' directory seems to contain the code of malicious package 'monorepo-symlink-test' #305

lanzkron opened this issue Jun 20, 2023 · 1 comment

Comments

@lanzkron
Copy link

Our security scanner reported that we have a malicious package 'monorepo-symlink-test' installed.
This package has been removed from npm but it appears to be embedded in the test directory (in directory /test/resolver/multirepo).
@ljharb
Copy link
Member

ljharb commented Jun 20, 2023

Seems to, but doesn’t. Your security scanner is incompetent, I’m afraid. the package.json has private: true, the fact that the name field is the same is irrelevant.

Duplicate of #303. Duplicate of #291. Duplicate of #288. Duplicate of #304.

@ljharb ljharb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
@ljharb ljharb mentioned this issue Jun 21, 2023
Closed
This was referenced Sep 1, 2023
Closed
Closed
Closed
Closed
@ljharb ljharb mentioned this issue Sep 8, 2023
Closed
This was referenced Sep 18, 2023
Closed
Closed
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] avoid publishing "malformed package.json" test to avoid flawe…
9e6f936 
…d security scanners

Fixes #319.
Fixes #318.
Fixes #317.
Fixes #314.
Closes #313.
Fixes #312.
Fixes #311.
Fixes #310.
Fixes #309.
Fixes #306.
Fixes #305.
Fixes #304.
Fixes #303.
Fixes #291.
Fixes #288.
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] rename innocent test project to avoid flawed security scanners
bce4768 
    Fixes #319.
    Fixes #318.
    Fixes #317.
    Fixes #314.
    Closes #313.
    Fixes #312.
    Fixes #311.
    Fixes #310.
    Fixes #309.
    Fixes #306.
    Fixes #305.
    Fixes #304.
    Fixes #303.
    Fixes #291.
    Fixes #288.
ljharb added a commit that referenced this issue Oct 10, 2023
@ljharb
[Tests] rename innocent test project to avoid flawed security scanners
c24f451 
    Fixes #319.
    Fixes #318.
    Fixes #317.
    Fixes #314.
    Closes #313.
    Fixes #312.
    Fixes #311.
    Fixes #310.
    Fixes #309.
    Fixes #306.
    Fixes #305.
    Fixes #304.
    Fixes #303.
    Fixes #291.
    Fixes #288.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @lanzkron