-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no longer reloading #260
Comments
+1 |
I can reproduce this issue at https://github.com/uwdata/vega-lite With 3.3, |
+1 |
@mattdesl It's probably this #250 (comment) #256 (comment) |
@domoritz I vega-lite at |
I updated Browserify from 11.0.0 to 11.0.1 and it started working again. |
Jup, works now in vega-lite with watchify 3.4. |
Still broken in 3.4.0 |
@mattymil Can you open a new issue? Please include a way to reproduce the problem |
Will do.
|
👍 |
I'm having the same problem with watch mode not working with watchify 3.4.0. Changes to watched files never trigger a recompile. This actually looks to have been introduced with watchify 3.3.1. I'm using grunt-browserify 3.8.0, which uses browserify 10.2.6 and watchify 3.4.0. My grunt-browserify tasks are straightforward, for example:
If I manually downgrade watchify to 3.3.0 watch mode works just fine again, but 3.3.1 and above do not work. Regardless, that's not a great solution since the semver dependency of watchify in grunt-browserify is I know we are a few versions behind on browserify, but our dependencies are pinned at the project level for the time being. |
@ptmccarthy You need browserify 11.0.1+ |
I've been having these issues for a long time now. Tried today with watchify 3.4.0, and let it pick it's own browserify 11.2.0. Still broken. Works a few times, then just stops working suddenly 😞 Also tried 3.2.2 which works twice and then stops reloading. Weird. Box |
Apparently, if I enable polling it works! |
@asbjornenge Then your issue is not with watchify but with chokidar. |
@mattdesl is this all cleared up? |
@vz8 That sounds like a chokidar issue |
Looks like the relevant issue has not been fixed in chokidar (paulmillr/chokidar#395). |
👍 I tried to use watchify and it was effectively just browserify. |
@1j01 Are you still affected by this? For what it's worth, I haven't seen this problem recently. |
@mattdesl Let me see... Yes. |
Looks like I'm experiencing this issue also. The chokidar issue looks to have been closed. Anything we can do to provide further clarification on the root cause? |
Using
grunt-browserify
with watch mode, wachify@3.3.1 does not reload on file change. If Icd
intonode_modules/grunt-browserify
andnpm install watchify@3.2.2
it reloads properly.The code is private, but if I get a chance I will try to boil it down to a smaller test repo.
The text was updated successfully, but these errors were encountered: