Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer reloading #260

Open
mattdesl opened this issue Aug 27, 2015 · 25 comments
Open

no longer reloading #260

mattdesl opened this issue Aug 27, 2015 · 25 comments

Comments

@mattdesl
Copy link
Contributor

Using grunt-browserify with watch mode, wachify@3.3.1 does not reload on file change. If I cd into node_modules/grunt-browserify and npm install watchify@3.2.2 it reloads properly.

The code is private, but if I get a chance I will try to boil it down to a smaller test repo.

@jennasalau
Copy link

+1

@domoritz
Copy link

I can reproduce this issue at https://github.com/uwdata/vega-lite

With 3.3, gulp serve gets stuck. With 3.2 everything is fine.

domoritz added a commit to vega/vega-lite that referenced this issue Aug 30, 2015
@jljorgenson18
Copy link

+1

@zertosh
Copy link
Member

zertosh commented Sep 2, 2015

@mattdesl It's probably this #250 (comment) #256 (comment)

@zertosh
Copy link
Member

zertosh commented Sep 2, 2015

@domoritz I vega-lite at 49ee1ca with watchify 3.3.1 and it works. Maybe you had an old version browserify? Try removing the node_modules directory and reinstalling your packages.

@jljorgenson18
Copy link

I updated Browserify from 11.0.0 to 11.0.1 and it started working again.

@domoritz
Copy link

domoritz commented Sep 2, 2015

Jup, works now in vega-lite with watchify 3.4.

@mattymil
Copy link

mattymil commented Sep 4, 2015

Still broken in 3.4.0

@zertosh
Copy link
Member

zertosh commented Sep 4, 2015

@mattymil Can you open a new issue? Please include a way to reproduce the problem

@mattymil
Copy link

mattymil commented Sep 4, 2015

Will do.

On Sep 4, 2015, at 1:08 PM, Andres Suarez notifications@github.com wrote:

@mattymil https://github.com/mattymil Can you open a new issue? Please include a way to reproduce the problem


Reply to this email directly or view it on GitHub #260 (comment).

@mightyiam
Copy link

👍

@ptmccarthy
Copy link

I'm having the same problem with watch mode not working with watchify 3.4.0. Changes to watched files never trigger a recompile. This actually looks to have been introduced with watchify 3.3.1.

I'm using grunt-browserify 3.8.0, which uses browserify 10.2.6 and watchify 3.4.0.

My grunt-browserify tasks are straightforward, for example:

browserify: {
  options: {
    browserifyOptions: {
      debug: true
    },
    watch: true
  },

  reports: {
    src: [
      '<%= config.src %>/reports/js/main.js',
      '<%= config.src %>/reports/templates/*.hbs'
    ],
      dest: '<%= config.dist %>/reports/js/reports.js'
  }
}

If I manually downgrade watchify to 3.3.0 watch mode works just fine again, but 3.3.1 and above do not work. Regardless, that's not a great solution since the semver dependency of watchify in grunt-browserify is ^3.2.1 which will always download 3.4.0 from npm.

I know we are a few versions behind on browserify, but our dependencies are pinned at the project level for the time being.

@zertosh
Copy link
Member

zertosh commented Sep 23, 2015

@ptmccarthy You need browserify 11.0.1+

@asbjornenge
Copy link

I've been having these issues for a long time now. Tried today with watchify 3.4.0, and let it pick it's own browserify 11.2.0. Still broken. Works a few times, then just stops working suddenly 😞

Also tried 3.2.2 which works twice and then stops reloading. Weird.

Box
Ubuntu 14.10 / Linux 3.17.4 (ext4)
Node 0.12.2 & 4.1.1 (tried both)
Npm 2.14.4

@asbjornenge
Copy link

Apparently, if I enable polling it works! --poll=100 and it's back 😁

@zertosh
Copy link
Member

zertosh commented Oct 2, 2015

@asbjornenge Then your issue is not with watchify but with chokidar.

@zertosh
Copy link
Member

zertosh commented Oct 25, 2015

@mattdesl is this all cleared up?

@zertosh
Copy link
Member

zertosh commented Nov 8, 2015

@vz8 That sounds like a chokidar issue

@quentindemetz
Copy link

Looks like the relevant issue has not been fixed in chokidar (paulmillr/chokidar#395).

@1j01
Copy link

1j01 commented Jan 13, 2016

👍 I tried to use watchify and it was effectively just browserify.

@mattdesl
Copy link
Contributor Author

@1j01 Are you still affected by this?

For what it's worth, I haven't seen this problem recently.

@1j01
Copy link

1j01 commented Jan 13, 2016

@mattdesl Let me see... Yes.

@PaulAik
Copy link

PaulAik commented Apr 13, 2016

Looks like I'm experiencing this issue also.

The chokidar issue looks to have been closed.

Anything we can do to provide further clarification on the root cause?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

13 participants