Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm gemm interface update #61

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

abhi-agg
Copy link

@abhi-agg abhi-agg commented Nov 1, 2021

Description

This PR improves on the interface introduced in #49

List of changes:

  • Added separate scale factor and zero point for both A and B in int8PrepareBias and int8MultiplyAndAddBias interface instead of pre-computing the unquantization value and passing it as a single parameter
  • An additional unquantization multiplier parameter in int8MultiplyAndAddBias
  • Updated the corresponding fallback implementation

Added dependencies: none

Checklist

  • I have tested the code manually
  • I have run regression tests
  • I have read and followed CONTRIBUTING.md
  • I have updated CHANGELOG.md

 - Added an additional unquantization multiplier
 - Added separate quantization parameters (scale and bias) for A and B
 - Addded additional unquantization multiplier
@abhi-agg abhi-agg requested review from XapaJIaMnu and kpu November 1, 2021 15:15
@abhi-agg
Copy link
Author

abhi-agg commented Nov 1, 2021

@kpu I made these changes as per our discussion in the last plenary meeting 👍🏾

@kpu
Copy link
Member

kpu commented Nov 3, 2021

I can't think of a use of the unquant_multiplier in prepareBias since it's just supposed to make the bias term ready. You seem you agree with that by not using it. Suggest removing it as an argument from the prepareBias call.
Keep the factor in the multiply though.
Then otherwise good to go.

@abhi-agg
Copy link
Author

abhi-agg commented Nov 3, 2021

@kpu I removed unquant_multiplier from prepareBias API as per your recommendation 👍🏾

@abhi-agg abhi-agg requested a review from kpu November 3, 2021 09:55
@abhi-agg abhi-agg merged commit 200e81c into browsermt:master Nov 3, 2021
@abhi-agg abhi-agg deleted the wasm-gemm-interface-update branch November 30, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants