Add copy actions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on master. |
maximbaz
approved these changes
Apr 21, 2018
| case "KeyC": | ||
| if (e.ctrlKey) { | ||
| result.doAction( | ||
| e.shiftKey ? "copyUsername" : "copyPassword" |
There was a problem hiding this comment.
In the original browserpass extension copy username was Shift+C, not Ctrl+Shift+C. I don't mind changing if you prefer this one (I actually like Ctrl+Shift+C more), just want to make sure it is a conscious decision on your side too.
| }, | ||
| { once: true } | ||
| ); | ||
| document.execCommand("copy"); |
There was a problem hiding this comment.
This looks too easy to be true 😃 Very interesting approach!
Just keep in mind, Firefox is special, it doesn't allow copying from background page, so we have to also send it to the popup and copy from the popup. I added this to the TODO document in case you want to confirm and deal with it separately.
There was a problem hiding this comment.
That's annoying - didn't realise that. TODO was a good idea.
fkneist
pushed a commit
to fkneist/browserpass-extension
that referenced
this pull request
Feb 12, 2022
* Add copy actions * Add hotkeys to search box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.