This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
Upgrade node-sass to v4 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @michaelhogg, thanks for the PR. Let's leave it in |
|
@shvaikalesh: Great, thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.jsonis currently requiring node-sass v3.8.0.It'd be good to upgrade to v4. I've been encountering this bug frequently, and it's been fixed in v4 🎉
The reason for the increment of the major semver from 3 to 4 seems to be this PR, which upgrades LibSass to v3.4.0 (a significant update).
I'm using this PR's upgrade-nodesass branch in my current Brunch project, and I haven't encountered any issues with the upgrade to node-sass v4.