Added new routes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey I just tested this fork, this is really cool, thanks for the PR! |
|
You're welcome, thanks to you ! |
|
Hum, I just saw you reverted the PR (I wanna use master to add some tests). Did you find any bugs in my code ? |
|
I reverted the PR on master since I wanted to re-structure the project to better accommodate your changes, until then I made a separate branch with all your changes. |
Closed
|
@prytoegrian just pushed to main all your changes, made some minor fixes, thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. #1
Hi ! Following #1, I added some new routes. They are neither very useful nor interesting, but I hope they could entertain someone. Now, each
QuoteTypehas a score and a uuid for sort and selection purpose.I added :
/one/{uuid}/top/one/{uuid}/like/one/{uuid}/dislikeThe routes
/one/{uuid}/likeand/one/{uuid}/dislikedon't follow ReST best practices since this principle forbid verbs in routes but I failed to find a way to represent what I wanted to build. If you have any idea, I'll take it with pleasure.If, for a reason or another, you don't approve this PR, I won't mind. I really enjoyed play with your software and practice my golang.
Regards.