Add Senile Route #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey i just reviewed your PR everything looks good and I like the name! thanks for creating a |
|
Just did some minor testing and looks like your endpoint is returning a string, since this is REST API the responses should be in formats like JSON or XML. Don't worry though, I'm fixing it right now, since I have some spare time, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a route for issue #1 that randomly mashes strings together. It is highly configurable so feel free to change the numbers and play around with it. I got it in a good spot and it occasionally makes something cool, but it can be better. I hope you like it, I had fun making this. Also, I am not the best namer so if you don't like 'senile' make some suggestions and I will change it.