Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex misses links after \n or <br /> (ex: <br />http://google.com) #13

Open
hardy613 opened this issue Mar 17, 2014 · 4 comments
Open

Comments

@hardy613
Copy link

I made local changes the start of the regex

 (^|\s)

to

(^|[\n\s>])

and that is catching the missing edge cases. How it reads: from the start of the string or after any \n (newline) \s (space) or >

@bryanwoods
Copy link
Owner

Can you submit a PR with this change? 👍

@hardy613
Copy link
Author

for sure!

@JoshuaNovak919
Copy link

This still isn't updated.

@hardy613
Copy link
Author

hardy613 commented Dec 9, 2014

theres a fix in a PR I sent, it can be seen here
https://github.com/bryanwoods/autolink-js/tree/hardy613-master (NOTE: its
not the current branch)

On Tue, Dec 9, 2014 at 4:59 PM, JoshuaNovak919 notifications@github.com
wrote:

This still isn't updated.


Reply to this email directly or view it on GitHub
#13 (comment)
.

Scott Hardy

hardy613@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants