Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Rankine Cycle example is broken on Readthedocs #24

Closed
bryanwweber opened this issue Mar 3, 2020 · 0 comments · Fixed by #26
Closed

The Rankine Cycle example is broken on Readthedocs #24

bryanwweber opened this issue Mar 3, 2020 · 0 comments · Fixed by #26

Comments

@bryanwweber
Copy link
Owner

https://thermostate.readthedocs.io/en/latest/rankine-cycle-example.html#4.-plot-\eta-vs-y

For some reason,the dimensions of p are incorrect 🙁
bryanwweber added a commit that referenced this issue Apr 12, 2020
@bryanwweber
Fixes dimensionality error in Rankine example
ceaf370 
The Rankine cycle example had a dimensionality error due to the extra
units multiplication on the linspace. It seems like linspace includes
units now instead of dropping them.

Fixes #24
@bryanwweber bryanwweber mentioned this issue Apr 12, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Rankine Cycle Example bryanwweber/thermostate
1 participant
@bryanwweber