Support new query-stream API with HTTP/2 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In a later PR there should be support for the other new endpoints
|
|
@harlev that's great. Let met know if you complete this cool feature. |
|
@bryanyang0528 last two APIs are implemented |
# Conflicts: # ksql/client.py # tests/test_client.py
…into query-stream
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
===========================================
- Coverage 75.25% 65.24% -10.01%
===========================================
Files 7 7
Lines 396 469 +73
Branches 54 66 +12
===========================================
+ Hits 298 306 +8
- Misses 80 145 +65
Partials 18 18
Continue to review full report at Codecov.
|
|
@harlev Thanks for your contribution. Nice implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional support for the new HTTP/2 endpoint for queries, requested in #77
This is a non breaking change. The new endpoint will only be used when
use_http2=Trueis passed intoQueryin the client.Since it looks like Python's
requestsdoes not support HTTP/2, added the Hyper package.The test for Query was enhanced to test both HTTP/1.1 and HTTP/2 with the
/queryand/query-streamendpoints receptively