Applying pull request changes from rehanone#37

data/common.yaml

@@ -52,4 +52,5 @@ samba::machine_password_timeout: null
 samba::realm: null
 samba::kerberos_method: null
 samba::dedicated_keytab_file: null
-samba::obey_pam_restrictions: false
+samba::obey_pam_restrictions: false
+samba::idmap_config: {}

manifests/config.pp

@@ -45,5 +45,13 @@
     'obey pam restrictions':    value => $samba::obey_pam_restrictions;
   }
 
+  $samba::idmap_config.each | $idmap_domain, $idmap_options | {
+    $idmap_options.each | $idmap_option, $idmap_value | {
+      samba::option { "idmap config ${idmap_domain} : ${idmap_option}":
+        value => $idmap_value,
+      }
+    }
+  }
+
   create_resources('samba::share', $samba::shares)
 }

manifests/init.pp

@@ -155,6 +155,7 @@
   Optional[String] $kerberos_method,
   Optional[String] $dedicated_keytab_file,
   Optional[Boolean] $obey_pam_restrictions,
+  Optional[Hash] $idmap_config,
 
   Hash $shares = {},
 ) {

spec/classes/samba_spec.rb

@@ -93,10 +93,11 @@
           is_expected.to contain_samba__option('kerberos method').with_value(nil)
           is_expected.to contain_samba__option('dedicated keytab file').with_value(nil)
           is_expected.to contain_samba__option('obey pam restrictions').with_value(false)
+          is_expected.to contain_samba__option('idmap config').with_value({})
         }
 
         it {
-          is_expected.to have_samba__option_resource_count(32)
+          is_expected.to have_samba__option_resource_count(33)
         }
       end
 

spec/defines/option_spec.rb

@@ -101,6 +101,19 @@
           )
         }
       end
+
+      context 'with a hash as a value', :compile do
+        let(:title) { 'test' }
+        let(:params) { { value: {} } }
+
+        it {
+          is_expected.to contain_augeas('samba option (test=ssl tls)').with(
+            'incl' => '/etc/samba/smb.conf',
+            'lens' => 'Samba.lns',
+            'changes' => 'set "target[. = "global"]/test" "ssl tls"',
+          )
+        }
+      end
     end
   end
 end

spec/defines/share_spec.rb

@@ -43,7 +43,7 @@
         }
 
         it {
-          is_expected.to have_samba__option_resource_count(63)
+          is_expected.to have_samba__option_resource_count(64)
         }
       end
     end