Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Discord Webhook to use embeds instead of raw text to avoid 2000 character limit #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Burn-E99
Copy link

@Burn-E99 Burn-E99 commented Jan 6, 2023

Update Discord Webhook to use embeds instead of raw text to avoid 2000 character limit. This limit could be hit by alliance raids, and in extremely rare cases 8 man dungeons/raids.

Fixes issue #84

Before and After comparison:
image

Alliance Raid example:
image

Copy link
Owner

@bsides bsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok besides the file, are you sure combatantRow is only used for Discord? If so, this could pass with only that fix. Also, sorry for so much delay, I haven't noticed this.

@@ -24,3 +24,4 @@
npm-debug.log*
yarn-debug.log*
yarn-error.log*
Thumbs.db
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this file? Seems like it's not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants