Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jar's client manifest should have the version property set #159

Closed
bsideup opened this issue Jul 25, 2019 · 0 comments · Fixed by #202
Closed

Jar's client manifest should have the version property set #159

bsideup opened this issue Jul 25, 2019 · 0 comments · Fixed by #202

Comments

@bsideup
Copy link
Owner

bsideup commented Jul 25, 2019

btw can you add into manifest version? So that getPackageVersion on class will work?

https://github.com/testcontainers/testcontainers-java/blob/master/modules/mockserver/src/test/java/org/testcontainers/containers/MockServerContainerTest.java#L22

Originally posted by @lanwen in #155
@bsideup bsideup mentioned this issue Jul 25, 2019
Merged
@lanwen lanwen changed the title Jar's manifest should have the version property set Jar's client manifest should have the version property set Oct 8, 2019
lanwen added a commit that referenced this issue Oct 8, 2019
@lanwen
Add Implementation-Version to manifest for client/testing
e9d9588 
so that you can grab the version using
LiiklusClient.class.getPackage().getImplementationVersion()

Fixes #159
@lanwen lanwen mentioned this issue Oct 8, 2019
Merged
bsideup pushed a commit that referenced this issue Oct 20, 2019
@lanwen @bsideup
Add Implementation-Version to every JAR manifest (#202)
0e9fd2a 
* Add Implementation-Version to manifest for client/testing

so that you can grab the version using
LiiklusClient.class.getPackage().getImplementationVersion()

Fixes #159

* move manifest options to the root build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Implementation-Version to manifest for client/testing bsideup/liiklus
1 participant
@bsideup