positions storage tck #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Aug 1, 2018
| void setUp() { | ||
| dynamoDB.createTable(new CreateTableRequest( | ||
| asList( | ||
| new AttributeDefinition("topic", ScalarAttributeType.S), |
There was a problem hiding this comment.
plz use constants from DynamoDBPositionsStorage
bsideup
reviewed
Aug 1, 2018
| .concat( | ||
| asDeferMono(() -> getStorage().update(getTopic(), groupId, 2, 2)), | ||
| asDeferMono(() -> getStorage().update(getTopic(), groupId2, 2, 3)), | ||
| asDeferMono(() -> getStorage().update(getTopic() + 1, groupId2, 2, 4)), |
There was a problem hiding this comment.
+1 looks weird here, would be better to extract a variable and use a random topic name instead.
Also, probably makes sense to not have getTopic() method at all, but use val topic = UUID.randomUUID().toString() in every test
bsideup
reviewed
Aug 1, 2018
| default void shouldSavePosition() { | ||
| GroupId groupId = GroupId.ofString(UUID.randomUUID().toString()); | ||
|
|
||
| Map<Integer, Long> positions = asDeferMono(() -> getStorage().update(getTopic(), groupId, 2, 2)) |
There was a problem hiding this comment.
what if instead of asDeferMono we use await(getStorage().update(getTopic(), groupId, 2, 2)), where await is something like:
<T> T await(CompletionStage<T> future) {
return future.toCompetableFuture().get(10, SECONDS);
}
?
bsideup
reviewed
Aug 2, 2018
| import static java.util.Arrays.asList; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public interface PositionsStorageTests extends PositionsStorageTestSupport { |
There was a problem hiding this comment.
could you please split this into a few (akin Records Storage TCK)?
e.g. GroupsTest, PersistenceTest, etc.
It will also make it easy to add more tests & categories in future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.