Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc reflection service #143

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Add grpc reflection service #143

merged 1 commit into from
Jul 12, 2019

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Jul 12, 2019

User (and client services) can now inspect the metadata without
having to know the .proto definitions. E.g:

$ grpcurl -plaintext localhost:6565 describe
com.github.bsideup.liiklus.LiiklusService is a service:
service LiiklusService {
  rpc Ack ( .com.github.bsideup.liiklus.AckRequest ) returns ( .google.protobuf.Empty );
  rpc GetEndOffsets ( .com.github.bsideup.liiklus.GetEndOffsetsRequest ) returns ( .com.github.bsideup.liiklus.GetEndOffsetsReply );
  rpc GetOffsets ( .com.github.bsideup.liiklus.GetOffsetsRequest ) returns ( .com.github.bsideup.liiklus.GetOffsetsReply );
  rpc Publish ( .com.github.bsideup.liiklus.PublishRequest ) returns ( .com.github.bsideup.liiklus.PublishReply );
  rpc Receive ( .com.github.bsideup.liiklus.ReceiveRequest ) returns ( stream .com.github.bsideup.liiklus.ReceiveReply );
  rpc Subscribe ( .com.github.bsideup.liiklus.SubscribeRequest ) returns ( stream .com.github.bsideup.liiklus.SubscribeReply );
}

User (and client services) can now inspect the metadata without
having to know the .proto definitions. E.g:

$ grpcurl -plaintext localhost:6565 describe
com.github.bsideup.liiklus.LiiklusService is a service:
service LiiklusService {
  rpc Ack ( .com.github.bsideup.liiklus.AckRequest ) returns ( .google.protobuf.Empty );
  rpc GetEndOffsets ( .com.github.bsideup.liiklus.GetEndOffsetsRequest ) returns ( .com.github.bsideup.liiklus.GetEndOffsetsReply );
  rpc GetOffsets ( .com.github.bsideup.liiklus.GetOffsetsRequest ) returns ( .com.github.bsideup.liiklus.GetOffsetsReply );
  rpc Publish ( .com.github.bsideup.liiklus.PublishRequest ) returns ( .com.github.bsideup.liiklus.PublishReply );
  rpc Receive ( .com.github.bsideup.liiklus.ReceiveRequest ) returns ( stream .com.github.bsideup.liiklus.ReceiveReply );
  rpc Subscribe ( .com.github.bsideup.liiklus.SubscribeRequest ) returns ( stream .com.github.bsideup.liiklus.SubscribeReply );
}
@bsideup bsideup added this to the next milestone Jul 12, 2019
@bsideup bsideup added the enhancement New feature or request label Jul 12, 2019
@bsideup bsideup merged commit 5e6a1e1 into bsideup:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants