Pulsar: TLS and Authentication support #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rowanto, Could you please add an integration test for it? This sounds like a sensible setting and it would be better to have it tested. Thanks! |
Rowanto
force-pushed
the
pulsar-tls-and-auth
branch
5 times, most recently
from
16fb39c
to
f3eedbe
Compare
Rowanto
force-pushed
the
pulsar-tls-and-auth
branch
from
f3eedbe
to
81d7932
Compare
|
Added integration tests for TLS and TLS + Auth. |
|
@bsideup ping |
|
@Rowanto thanks for the ping, I will review it later today. I have a few things to cleanup in tests, will apply the changes myself and push to your branch before merging, just FYI |
|
@Rowanto I pushed the changes I made yesterday, could you please take a look? |
lanwen
reviewed
Aug 1, 2019
...est/java/com/github/bsideup/liiklus/pulsar/config/PulsarRecordsStorageConfigurationTest.java
Show resolved
Hide resolved
lanwen
approved these changes
Aug 1, 2019
bsideup
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.