Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulsar: test that eventTime is preferred over publishTime #178

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Pulsar: test that eventTime is preferred over publishTime #178

merged 2 commits into from
Aug 30, 2019

Conversation

bsideup
Copy link
Owner

@bsideup bsideup commented Aug 29, 2019

Extracted from #176

@bsideup bsideup added this to the next milestone Aug 29, 2019
@bsideup bsideup mentioned this pull request Aug 29, 2019
Merged
@bsideup
Copy link
Owner Author

bsideup commented Aug 29, 2019

@Rowanto please take a look as well

@bsideup bsideup mentioned this pull request Aug 29, 2019
Closed
@lanwen
Copy link
Collaborator

lanwen commented Aug 29, 2019

btw shouldn't liiklus have the same separation in the record - event and publish time?

@bsideup
Copy link
Owner Author

bsideup commented Aug 29, 2019

@lanwen it was never exposed, plus some systems do not support this separation

For manually defined timestamps it is better to explicitly have it in the payload

@Rowanto
Copy link
Contributor

Rowanto commented Aug 30, 2019

looks good.

@bsideup bsideup merged commit 43d825c into master Aug 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the Rowanto_pulsar_add_eventTime_test branch August 30, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin/pulsar
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bsideup @lanwen @Rowanto