Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-partitioned Pulsar topics #260

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

bsideup
Copy link
Owner

@bsideup bsideup commented Feb 6, 2020

Apparently, Pulsar uses a magical -1 value for the partition number when the topic is not partitioned.

@bsideup bsideup added bug Something isn't working plugin/pulsar labels Feb 6, 2020
@bsideup bsideup added this to the next milestone Feb 6, 2020
@bsideup bsideup requested a review from lanwen February 6, 2020 17:19
scothis added a commit to scothis/system that referenced this pull request Feb 6, 2020
scothis added a commit to scothis/system that referenced this pull request Feb 6, 2020
@scothis
Copy link

scothis commented Feb 6, 2020

Works with riff https://github.com/projectriff/system/pull/316/checks?check_run_id=430254630

@bsideup bsideup merged commit ba08641 into master Feb 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix_non_partitioned_pulsar_topics branch February 6, 2020 21:06
scothis added a commit to projectriff/system that referenced this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin/pulsar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants