Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate random names to read end offsets in subscription #263

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Don't generate random names to read end offsets in subscription #263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b317a9
Don't generate random names to read end offsets in subscription
lanwen Feb 13, 2020
828e79c
Update PulsarRecordsStorage.java
bsideup Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...records-storage/src/main/java/com/github/bsideup/liiklus/pulsar/PulsarRecordsStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import java.time.Instant;
import java.util.Map;
import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.CompletionStage;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
Expand All @@ -29,6 +28,8 @@
@FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)
public class PulsarRecordsStorage implements FiniteRecordsStorage {

private static final String SUBSCRIPTION_NAME = "liiklus-end-offsets-reader";

public static MessageId fromOffset(long offset) {
return new MessageIdImpl(offset >>> 28, offset & 0x0F_FF_FF_FFL, -1);
}
Expand Down Expand Up @@ -102,7 +103,7 @@ public CompletionStage<Map<Integer, Long>> getEndOffsets(String topic) {
var partitionIndex = TopicName.getPartitionIndex(partitionTopic);

var consumerFuture = pulsarClient.newConsumer()
.subscriptionName(UUID.randomUUID().toString())
.subscriptionName(SUBSCRIPTION_NAME)
.subscriptionType(SubscriptionType.Failover)
.topic(partitionTopic)
.subscribeAsync();
Expand Down