Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot config #289

Merged
merged 6 commits into from
May 22, 2020
Merged

Add dependabot config #289

merged 6 commits into from
May 22, 2020

Conversation

lanwen
Copy link
Collaborator

@lanwen lanwen commented Mar 20, 2020

No description provided.

@bsideup
Copy link
Owner

bsideup commented Mar 20, 2020

@lanwen could you please clarify?
The idea was to have only shared dependencies in the main build.gradle, since other dependencies are per-plugin and don't have to share the same version

@lanwen
Copy link
Collaborator Author

lanwen commented Mar 20, 2020

In practice, all the core plugins should be quite aligned on the versions used, so why to hide versions deeply in the plugin? :)

However, I can add dependabot to track each plugin independently, that should solve the original issue as well. Will be that better from your side?

@bsideup
Copy link
Owner

bsideup commented Mar 20, 2020

@lanwen ah, okay, I see the issue with Dependabot. Yes, I would rather make Dependabot work with them then :)

@lanwen lanwen changed the title Move pulsar dependency management to main build.gradle Add dependabot config Mar 24, 2020
@lanwen lanwen requested a review from bsideup March 24, 2020 13:54
@lanwen
Copy link
Collaborator Author

lanwen commented Mar 24, 2020

ah, wildcards won't work
https://github.com/dependabot/feedback/issues/408

@bsideup
Copy link
Owner

bsideup commented Mar 24, 2020

@lanwen not needed in this PR, but:
We could also add a GitHub Action that will update the config on each push automatically, in case we add more plugins

@lanwen
Copy link
Collaborator Author

lanwen commented Mar 24, 2020

For now it doesn't look like a lot of mainteinance manually :D

@lanwen
Copy link
Collaborator Author

lanwen commented Apr 7, 2020

@bsideup any blockers for this one?

- package_manager: "docker"
directory: "/"
update_schedule: "daily"
# Plugins Dependencies
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add entries for every plugin that we have?
https://github.com/bsideup/liiklus/tree/master/plugins

I am also thinking whether we should do it in settings.gradle and simply list them there, so that it is always in sync?

include projectName
project(":${projectName}").projectDir = dir
if (findProject(":plugins:${projectName}") == null) {
throw new GradleException("Plugin /plugins/${projectName} was not included into the build. Check settings.gradle for details.")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice idea! 👍

@bsideup bsideup added this to the next milestone May 22, 2020
@bsideup bsideup added the dependencies Pull requests that update a dependency file label May 22, 2020
@bsideup bsideup merged commit 4956d49 into master May 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the pulsar branch May 22, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants