Update RSocket to 1.0.1 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
added
dependencies
lanwen
reviewed
Jul 28, 2020
| .flatMapIterable(it -> it::iterator) | ||
| .flatMapIterable(it -> { | ||
| var iterator = it.iterator(); | ||
| return () -> iterator; |
There was a problem hiding this comment.
can you give some insights on this expansion?
There was a problem hiding this comment.
there was a change in Reactor that made it call Iterable#iterator two times (completely valid) but, in case of Streams, one can call Iterable#iterator only once, hence the change :)
lanwen
reviewed
Jul 28, 2020
|
|
||
| public interface RSocketServerConfigurer { | ||
|
|
||
| void apply(RSocketServer server); |
There was a problem hiding this comment.
oh, thats great, would simplify auth plugin 👍🏻
lanwen
approved these changes
Jul 28, 2020
lanwen
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.