Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle to 7.1.1 #954

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Update gradle to 7.1.1 #954

merged 3 commits into from
Jul 22, 2021

Conversation

lanwen
Copy link
Collaborator

@lanwen lanwen commented Jul 8, 2021

No description provided.

@lanwen lanwen requested a review from bsideup July 11, 2021 22:00
@lanwen lanwen marked this pull request as ready for review July 12, 2021 14:21
@lanwen
Copy link
Collaborator Author

lanwen commented Jul 12, 2021

found that im missing publication section, will add

@lanwen
Copy link
Collaborator Author

lanwen commented Jul 12, 2021

Checked with a small script the difference across configurations, should be fine now

def printfiles(String sep, Set<File> one, Set<File> two) {
    println "---->"
    println sep + (one - two).collect {it -> it.name}.join("\n" + sep)
}

tasks.register("printConfigurations") {

    dependsOn jar
    doLast {
        printfiles("", configurations.compile.resolve(), configurations.compileOnly.resolve())
        printfiles("", configurations.runtimeClasspath.resolve(), configurations.compileOnly.resolve())
        printfiles(" ▶︎ ", configurations.compileClasspath.resolve(), configurations.compileOnly.resolve())
        printfiles(" -- ", configurations.runtimeClasspath.resolve(), configurations.compileClasspath.resolve())
    }
}

also checked with jitpack current branch that it builds and passes internal tests on our installation (which means artifacts got published well and without something unexpected)

@bsideup bsideup merged commit 9342b29 into master Jul 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-deps-v2 branch July 22, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants